Skip to content

Conversation

@bkioshn
Copy link
Contributor

@bkioshn bkioshn commented Sep 20, 2024

Description

Fix test for draft11

Related Issue(s)

#21

Description of Changes

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@bkioshn bkioshn marked this pull request as draft September 20, 2024 03:51
@bkioshn bkioshn changed the title Test/c509 test v11 test(rust/c509-certificate) Fix test for draft11 Sep 20, 2024
@bkioshn bkioshn changed the title test(rust/c509-certificate) Fix test for draft11 test(rust/c509-certificate): Fix test for draft11 Sep 20, 2024
@bkioshn bkioshn marked this pull request as ready for review September 20, 2024 09:14
@bkioshn bkioshn added the enhancement New feature or request label Sep 20, 2024
@stevenj stevenj added the review me PR is ready for review label Sep 20, 2024
@stevenj stevenj merged commit b288110 into feat/c509-v11 Sep 21, 2024
@stevenj stevenj deleted the test/c509-test-v11 branch September 21, 2024 08:50
stevenj added a commit that referenced this pull request Oct 7, 2024
* fix: remove PEN supported

* fix(rust/c509-certificate): time

* fix(rust/c509-certificate): handle if issuer not set, set to subject

* fix(rust/c509-certificate): remove rdn

* fix(rust/c509-certificate): change certificate version number

* fix(rust/c509-certificate): rearrange tbscertificate

* fix(rust/c509-certificate): update docs

* fix(rust/c509-certificate): format + err handling

* fix(rust/c509-certificate): Rename functions + add necessary functions (#26)

* fix: naming + add neccesary function

* fix(rust/c509-certificate): cleanup

* fix(rust/c509-certificate): cleanup

---------

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>

* fix(rust/c509-certificate): CBOR decode encode helper (#27)

* fix: naming + add neccesary function

* fix(rust/c509-certificate): add encode + decode helper functions

* fix(rust/c509-certificate): cleanup

* fix(rust/c509-certificate): cleanup

* fix(rust/c509-certificate): cleanup

* fix(rust/c509-certificate): remove unnecessary allow(dead_code)

* fix(rust/c509-certificate): generic encode and decode functions

* test(rust/c509-certificate): Fix test for draft11 (#28)

* fix: naming + add neccesary function

* fix(rust/c509-certificate): add encode + decode helper functions

* fix(rust/c509-certificate): cleanup

* fix(rust/c509-certificate): cleanup

* fix(rust/c509-certificate): cleanup

* fix(rust/c509-certificate): remove unnecessary allow(dead_code)

* fix(rust/c509-certificate): fix encode decode Name

* chore(rust/c509-certificate): fix comment

* fix(rust/c509-certificate): add + rewrite test cases

* chore(rust/c509-certificate): earthly no cache

* chore(rust/c509-certificate): earthly no cache

* chore(rust/c509-certificate): earthly no cache

* chore(rust/c509-certificate): remove earthly no-cache

* fix(rust/c509-certificate): add more test comments

* fix(rust/c509-certificate): clippy lints

---------

Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
Co-authored-by: Steven Johnson <sakurainds@gmail.com>

* test(rust/c509-certificate): break the cache

* fix(rust): Lint and lintfix locally in release build mode

* test(rust/c509-certificate): rename tbs_cert.rs to cert_tbs.rs to test caching in CI

* docs(rust/cardano-chain-follower): Fix list of enhancements we could do to the chain follower

* ci(rust): Don't break the cache now in a build, but do check the cached src == the expected src

* test(rust): In an abundance of caution make sure cached src isn't used in the cache check target

* fix(rust) earthfile

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix(rust/c509-certificate): update docs  (#39)

* fix(rust/c509-certificate): docs

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix(rust/c509-certificate): spelling

Signed-off-by: bkioshn <bkioshn@gmail.com>

* fix(rust/c509-certificate): anyhow format

Signed-off-by: bkioshn <bkioshn@gmail.com>

* docs(rust/c509-certificate): make doc clearer

Signed-off-by: bkioshn <bkioshn@gmail.com>

---------

Signed-off-by: bkioshn <bkioshn@gmail.com>

---------

Signed-off-by: bkioshn <bkioshn@gmail.com>
Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com>
Co-authored-by: Steven Johnson <sakurainds@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request review me PR is ready for review

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants