fix(rust/c509-certificate): update docs #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <bkioshn@gmail.com>
Signed-off-by: bkioshn <bkioshn@gmail.com>
bkioshn
added
documentation
Mr-Leshiy
requested changes
Oct 2, 2024
Signed-off-by: bkioshn <bkioshn@gmail.com>
neil-iohk
reviewed
Oct 2, 2024
Contributor
neil-iohk
left a comment
neil-iohk
left a comment
There was a problem hiding this comment.
A few wording suggestions for comments.
Signed-off-by: bkioshn <bkioshn@gmail.com>
stevenj
added a commit
that referenced
this pull request
Oct 7, 2024
* fix: remove PEN supported * fix(rust/c509-certificate): time * fix(rust/c509-certificate): handle if issuer not set, set to subject * fix(rust/c509-certificate): remove rdn * fix(rust/c509-certificate): change certificate version number * fix(rust/c509-certificate): rearrange tbscertificate * fix(rust/c509-certificate): update docs * fix(rust/c509-certificate): format + err handling * fix(rust/c509-certificate): Rename functions + add necessary functions (#26) * fix: naming + add neccesary function * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup --------- Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com> * fix(rust/c509-certificate): CBOR decode encode helper (#27) * fix: naming + add neccesary function * fix(rust/c509-certificate): add encode + decode helper functions * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): remove unnecessary allow(dead_code) * fix(rust/c509-certificate): generic encode and decode functions * test(rust/c509-certificate): Fix test for draft11 (#28) * fix: naming + add neccesary function * fix(rust/c509-certificate): add encode + decode helper functions * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): cleanup * fix(rust/c509-certificate): remove unnecessary allow(dead_code) * fix(rust/c509-certificate): fix encode decode Name * chore(rust/c509-certificate): fix comment * fix(rust/c509-certificate): add + rewrite test cases * chore(rust/c509-certificate): earthly no cache * chore(rust/c509-certificate): earthly no cache * chore(rust/c509-certificate): earthly no cache * chore(rust/c509-certificate): remove earthly no-cache * fix(rust/c509-certificate): add more test comments * fix(rust/c509-certificate): clippy lints --------- Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com> Co-authored-by: Steven Johnson <sakurainds@gmail.com> * test(rust/c509-certificate): break the cache * fix(rust): Lint and lintfix locally in release build mode * test(rust/c509-certificate): rename tbs_cert.rs to cert_tbs.rs to test caching in CI * docs(rust/cardano-chain-follower): Fix list of enhancements we could do to the chain follower * ci(rust): Don't break the cache now in a build, but do check the cached src == the expected src * test(rust): In an abundance of caution make sure cached src isn't used in the cache check target * fix(rust) earthfile Signed-off-by: bkioshn <bkioshn@gmail.com> * fix(rust/c509-certificate): update docs (#39) * fix(rust/c509-certificate): docs Signed-off-by: bkioshn <bkioshn@gmail.com> * fix(rust/c509-certificate): spelling Signed-off-by: bkioshn <bkioshn@gmail.com> * fix(rust/c509-certificate): anyhow format Signed-off-by: bkioshn <bkioshn@gmail.com> * docs(rust/c509-certificate): make doc clearer Signed-off-by: bkioshn <bkioshn@gmail.com> --------- Signed-off-by: bkioshn <bkioshn@gmail.com> --------- Signed-off-by: bkioshn <bkioshn@gmail.com> Co-authored-by: Steven Johnson <stevenj@users.noreply.github.com> Co-authored-by: Steven Johnson <sakurainds@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating outdated doc for c509 certificate crate
https://datatracker.ietf.org/doc/draft-ietf-cose-cbor-encoded-cert/11/
Related Issue(s)
Closes #21
Please confirm the following checks