Centralize IOG library lists in iog-libs.nix#240
Merged
Conversation
Extract the duplicated IOG dependency lists from dynamic.nix, static.nix, cross-js.nix, and cross-windows.nix into a single iog-libs.nix file. This eliminates manual synchronization when adding new libraries (e.g., lmdb was previously missing from cross-compilation targets) and provides a canonical source of truth for IOG-specific dependencies. The centralized file categorizes dependencies into: - crypto: libblst, libsodium-vrf, secp256k1 (all shell types) - data: lmdb (dynamic/static only) - tools: cbor-diag, cddl, gh, icu, jq, yq-go (dynamic/static) - cross-tools: cbor-diag, cddl (cross-compilation targets) Each consumer imports iog-libs.nix and transforms as needed (e.g., static.nix passes static=true to resolve static-* variants). Addresses #56
Move the iog-libs.nix sync comment from inside the shell heredoc (where it breaks line continuation and triggers SC2215) to a Nix comment above the writeShellApplicationWithRuntime block.
angerman
force-pushed
the
fix/centralize-iog-libs
branch
from
482dddb to
c7b22a3
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dynamic.nix,static.nix,cross-js.nix, andcross-windows.nixinto a singleiog-libs.nixcrypto(all shells),data(dynamic/static),tools(dynamic/static),cross-tools(cross-compilation)feature/add-lmdbAddresses #56
Test plan
nix flake show— all devShells/hydraJobs evaluate without errorsnix eval '.#devShells.aarch64-darwin.ghc96-iog.buildInputs'— verified lmdb, libblst, libsodium-vrf, secp256k1 presentnix eval '.#devShells.aarch64-darwin.ghc96-static-iog.buildInputs'— verified static variants present with lmdb