Fix container upload when Hydra skips individual check-runs#242
Merged
Conversation
When Hydra resolves builds from cache, it creates only aggregate "required" check-runs but not individual per-build check-runs. This causes the GHA upload workflow to discover zero -env closures and skip all container uploads. Add a fallback path: when no Hydra check-runs ending in "-env" are found, evaluate the store paths directly from the flake using nix eval with extra/discover-env.nix. This ensures containers are always uploaded regardless of Hydra's check-run behavior. Also install Nix and checkout the repo in the Discover step to support the fallback evaluation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
requiredcheck-runs — not individual per-build check-runs likex86_64-linux.ghc96-iog-env-envclosures, producing an empty matrix and skipping all container uploadsnix evalwithextra/discover-env.nixContext
After merging #239 and #240, the container upload workflows failed 3 consecutive times because Hydra completed all builds from cache without creating individual GitHub check-runs. This is the root cause of the upload failures on the current
main.Test plan
nix evalproduces the correct matrix (locally tested the Nix expression)