[EC-206] Implement eth_getTransactionReceipt #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlanVerbner
reviewed
Jun 19, 2017
| import io.iohk.ethereum.utils.ByteUtils | ||
| import org.spongycastle.crypto.digests.{SHA1Digest, SHA256Digest} | ||
| import org.spongycastle.crypto.engines.AESFastEngine | ||
| import org.spongycastle.crypto.engines.AESEngine |
Contributor
Author
There was a problem hiding this comment.
org.spongycastle.crypto.engines.AESFastEngine is deprecated now
AlanVerbner
reviewed
Jun 19, 2017
| logs: Seq[TxLog] | ||
| ) | ||
|
|
||
| //TODO extract to top level because it is used in FilterManager.scala |
Contributor
There was a problem hiding this comment.
Does this need to be addressed in this PR?
Contributor
Author
There was a problem hiding this comment.
this should be addressed after #218 is merged
Contributor
There was a problem hiding this comment.
Ok, I would merge this one and create a new task, what do you think?
ntallar
reviewed
Jun 19, 2017
| receipt: Receipt <- receipts.lift(txIndex) | ||
| } yield { | ||
|
|
||
| //transaction with contract creation 0xb7b8cc9154896b25839ede4cd0c2ad193adf06489fdd9c0a9dfce05620c04ec1 |
There was a problem hiding this comment.
Minor detail: What does 0xb7b8cc9154896b25839ede4cd0c2ad193adf06489fdd9c0a9dfce05620c04ec1 represent? From the tests it seems to be the hash of a tx, maybe we should remove this comment?
Contributor
Author
There was a problem hiding this comment.
nwm I thought this is EthServiceSpec, I will remove it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.