Conversation
Contributor
Unit Tests Summary 1 files 58 suites 3m 23s ⏱️ Results for commit b80ab97. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 1a723c1 ♻️ This comment has been updated with latest results. |
shajoezhu
requested changes
Jan 23, 2025
shajoezhu
approved these changes
Jan 23, 2025
Contributor
shajoezhu
left a comment
There was a problem hiding this comment.
lgtm! thanks to Tim's explaination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug spotted by @barnett11 in lbt05
This is due to the fact the
PARAMis expected to be a factor by thelevelfunction. Automatic conversion to factor can cause unexpected behavior and is, in general, avoided.Defensive approach is to modify the assertion to force
PARAMto be a factor.thank you for the review