Skip to content

823 prune lbt07 to always keep any row@main#825

Merged
BFalquet merged 15 commits intomainfrom
823-prune-lbt07-to-always-keep-any-row@main
Mar 12, 2025
Merged

823 prune lbt07 to always keep any row@main#825
BFalquet merged 15 commits intomainfrom
823-prune-lbt07-to-always-keep-any-row@main

Conversation

@BFalquet
Copy link
Copy Markdown
Contributor

close #823

  • new arguments to control the behavior of the lbt05 and lbt07 postprocessing to avoid pruning essential rows.

  • fixing a bug in lbt05 where rows with non-zero data were punned when prune_0 = TRUE

  • new utility functions for prunning.

  • new map argument in lbt05 to specify the direction of abnormality

  • add tests

  • update snaphots

  • update NEWS

thank you for the review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2025

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------
R/ael01_nollt.R                  6       0  100.00%
R/ael02.R                       27       0  100.00%
R/ael03.R                       34       0  100.00%
R/aet01_aesi.R                 148       1  99.32%   214
R/aet01.R                      104       5  95.19%   77-80, 183
R/aet02.R                       44       0  100.00%
R/aet03.R                       76       0  100.00%
R/aet04.R                       88       0  100.00%
R/aet05_all.R                   11       0  100.00%
R/aet05.R                       44       1  97.73%   116
R/aet10.R                       42       0  100.00%
R/assertions.R                  93       7  92.47%   11-16, 123
R/cfbt01.R                     107       0  100.00%
R/checks.R                      14       0  100.00%
R/chevron_tlg-S4class.R         24       0  100.00%
R/chevron_tlg-S4methods.R      163       0  100.00%
R/cml02a_gl.R                    8       0  100.00%
R/cmt01a.R                      52       0  100.00%
R/coxt01.R                      49       1  97.96%   130
R/dmt01.R                       38       0  100.00%
R/dst01.R                       94       0  100.00%
R/dtht01.R                     102       6  94.12%   51, 55-59
R/egt02.R                       35       0  100.00%
R/egt03.R                       80       1  98.75%   157
R/egt05_qtcat.R                 78       0  100.00%
R/ext01.R                       85       2  97.65%   57, 213
R/fstg01.R                      43       0  100.00%
R/fstg02.R                      48       0  100.00%
R/kmg01.R                       35       6  82.86%   35-40
R/lbt01.R                       59       0  100.00%
R/lbt04.R                       90       0  100.00%
R/lbt05.R                      138       1  99.28%   55
R/lbt06.R                       70       0  100.00%
R/lbt07.R                       93       0  100.00%
R/lbt14.R                       64       0  100.00%
R/lbt15.R                       20       0  100.00%
R/mht01.R                       55       0  100.00%
R/mng01.R                       97      12  87.63%   86, 90-94, 126-130, 133, 178
R/pdt01.R                       60       0  100.00%
R/pdt02.R                       68       0  100.00%
R/report_null.R                 29       0  100.00%
R/rmpt01.R                      59       1  98.31%   132
R/rmpt06.R                     134       3  97.76%   209-212
R/rspt01.R                      73       3  95.89%   156-159
R/rtables_utils.R              319      23  92.79%   51, 68, 119, 243, 264, 372-379, 446, 461-463, 465, 534-540, 550, 571
R/standard_rules.R              13       0  100.00%
R/ttet01.R                     121       3  97.52%   203-206
R/unwrap.R                      36       0  100.00%
R/utils.R                      193      13  93.26%   299-302, 306-309, 336, 340, 352, 354, 368
R/vst02.R                       45       1  97.78%   109
R/zzz.R                          1       1  0.00%    2
TOTAL                         3609      91  97.48%

Diff against main

Filename                     Stmts    Miss  Cover
-------------------------  -------  ------  --------
R/ael01_nollt.R                -15      -1  +4.76%
R/ael02.R                      +27       0  +100.00%
R/ael03.R                      +34       0  +100.00%
R/aet01_aesi.R                  -2       0  -0.01%
R/aet01.R                      +10      +4  -3.74%
R/aet02.R                       -6       0  +100.00%
R/aet03.R                       -1       0  +100.00%
R/aet04.R                       -1       0  +100.00%
R/aet05.R                       +4       0  +0.23%
R/aet10.R                       -1       0  +100.00%
R/assertions.R                  -6      +1  -1.47%
R/chevron_tlg-S4class.R         +6       0  +100.00%
R/chevron_tlg-S4methods.R      +27      -4  +2.94%
R/cml02a_gl.R                   +8       0  +100.00%
R/cmt01a.R                      -6      -6  +10.34%
R/coxt01.R                      +1       0  +0.04%
R/dmt01.R                       +9       0  +100.00%
R/dst01.R                       -1       0  +100.00%
R/dtht01.R                      -1       0  -0.06%
R/egt02.R                       -2       0  +100.00%
R/egt03.R                       +3       0  +0.05%
R/egt05_qtcat.R                 -1       0  +100.00%
R/ext01.R                      +25      +1  -0.69%
R/fstg01.R                      -7       0  +100.00%
R/fstg02.R                      -7       0  +100.00%
R/kmg01.R                       +6      +6  -17.14%
R/lbt01.R                      +59       0  +100.00%
R/lbt04.R                       -1       0  +100.00%
R/lbt05.R                      +71      -4  +6.74%
R/lbt06.R                       -2      -3  +4.17%
R/lbt07.R                       -1       0  +100.00%
R/lbt14.R                       -2       0  +100.00%
R/mht01.R                      -16       0  +100.00%
R/mng01.R                       +1     +11  -11.33%
R/pdt02.R                       -1       0  +100.00%
R/report_null.R                +29       0  +100.00%
R/rmpt01.R                      -6     -10  +15.23%
R/rmpt06.R                    +134      +3  +97.76%
R/rtables_utils.R              +19      +4  -0.88%
R/standard_rules.R              +2       0  +100.00%
R/ttet01.R                      +4       0  +0.08%
R/unwrap.R                     +36       0  +100.00%
R/utils.R                     +109     +13  -6.74%
R/vst02.R                       -1       0  -0.05%
R/zzz.R                         +1      +1  +100.00%
TOTAL                         +538     +16  -0.08%

Results for commit: 062ed4c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2025

Unit Tests Summary

  1 files   58 suites   3m 17s ⏱️
297 tests 296 ✅ 1 💤 0 ❌
744 runs  735 ✅ 9 💤 0 ❌

Results for commit 062ed4c.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 27, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
lbt05 💔 $2.60$ $+2.95$ $+49$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
lbt05 👶 $+0.78$ incomplete_map_argument_works_as_expected
lbt05 👶 $+0.69$ map_argument_works_as_expected
lbt05 👶 $+0.80$ prune_0_keeps_the_Any_Abnormaility_row

Results for commit 92b9369

♻️ This comment has been updated with latest results.

@shajoezhu shajoezhu self-assigned this Feb 27, 2025
Comment thread R/lbt05.R Outdated
Comment thread R/lbt05.R Outdated
Comment thread R/lbt07.R
Comment thread R/utils.R
Copy link
Copy Markdown
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add test for convert_to_month, various small comment

Copy link
Copy Markdown
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @BFalquet , minor comments to consider

@BFalquet BFalquet merged commit 8eff586 into main Mar 12, 2025
@BFalquet BFalquet deleted the 823-prune-lbt07-to-always-keep-any-row@main branch March 12, 2025 09:00
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Prune lbt07 to always keep "Any" row

2 participants