823 prune lbt07 to always keep any row@main#825
Merged
Conversation
Contributor
Code Coverage SummaryDiff against mainResults for commit: 062ed4c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Unit Tests Summary 1 files 58 suites 3m 17s ⏱️ Results for commit 062ed4c. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance Difference
Additional test case details
Results for commit 92b9369 ♻️ This comment has been updated with latest results. |
shajoezhu
reviewed
Mar 11, 2025
shajoezhu
reviewed
Mar 11, 2025
shajoezhu
reviewed
Mar 11, 2025
shajoezhu
reviewed
Mar 11, 2025
shajoezhu
requested changes
Mar 11, 2025
Contributor
shajoezhu
left a comment
There was a problem hiding this comment.
add test for convert_to_month, various small comment
…ny-row@main' into 823-prune-lbt07-to-always-keep-any-row@main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #823
new arguments to control the behavior of the
lbt05andlbt07postprocessing to avoid pruning essential rows.fixing a bug in
lbt05where rows with non-zero data were punned whenprune_0 = TRUEnew utility functions for prunning.
new
mapargument inlbt05to specify the direction of abnormalityadd tests
update snaphots
update NEWS
thank you for the review