Set default digits for tbl_roche_summary()#139
Merged
Conversation
Contributor
Unit Tests Summary 1 files 68 suites 1m 29s ⏱️ Results for commit ddd1735. ♻️ This comment has been updated with latest results. |
Contributor
Unit Test Performance DifferenceAdditional test case details
Results for commit 5925bba ♻️ This comment has been updated with latest results. |
tbl_roche_summary()tbl_roche_summary() and tbl_baseline_chg()
Contributor
Code Coverage SummaryDiff against mainResults for commit: ddd1735 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Contributor
Author
|
@khatril this PR should set default digit formatting (including NEs) as discussed in the chat. |
tbl_roche_summary() and tbl_baseline_chg()tbl_roche_summary()
shajoezhu
reviewed
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
digitsdefaults totbl_roche_summary()that utilize thelabel_roche_*()functions and estimate number of digits for each variable. Also affects functions that calltbl_roche_summary()internally.Variable decimal places estimated according to guidelines in "TLG General Reporting Conventions" document.
Closes #138
Pre-review Checklist (if item does not apply, mark is as complete)
usethis::pr_merge_main()devtools::test_coverage()Reviewer Checklist (if item does not apply, mark is as complete)
pkgdown::build_site(). Check the R console for errors, and review the rendered website.devtools::test_coverage()When the branch is ready to be merged:
NEWS.mdwith the changes from this pull request under the heading "# cards (development version)". If there is an issue associated with the pull request, reference it in parentheses at the end update (seeNEWS.mdfor examples).