Deprecate scatter plot in favor of correlation plot

[asbates]

Deprecates g_scatterplot and suggest using g_correlationplot instead.

Part of insightsengineering/teal.goshawk/issues/168

[github-actions]

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/g_boxplot.R                        108     108  0.00%    150-305
R/g_correlationplot.R                129     129  0.00%    252-414
R/g_density_distribution_plot.R       86      86  0.00%    126-237
R/g_lineplot.R                       256     256  0.00%    263-588
R/g_scatterplot.R                    123     123  0.00%    143-304
R/g_spaghettiplot.R                  100     100  0.00%    197-329
R/geom_axes_line.R                   167     167  0.00%    48-370
R/t_summarytable.R                   102     102  0.00%    88-225
R/utils.R                             68      68  0.00%    21-139
TOTAL                               1139    1139  0.00%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/g_scatterplot.R       +5      +5  -
TOTAL                   +5      +5  -

Results for commit: 84318d2

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[nikolas-burkoff]

We should also remove scatterplot from the README file and move it to a "deprecated functions" section in the pkgdown file - otherwise looks good

[nikolas-burkoff]

👍