Skip to content

add rmarkdown to VignetteBuilder - #260

Merged
pawelru merged 2 commits into
mainfrom
add_rmarkdown
Nov 12, 2024
Merged

add rmarkdown to VignetteBuilder#260
pawelru merged 2 commits into
mainfrom
add_rmarkdown

Conversation

@pawelru

@pawelru pawelru commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

fix nosuggest ci

@pawelru
pawelru requested a review from donyunardi October 24, 2024 15:15
@pawelru
pawelru enabled auto-merge (squash) October 24, 2024 15:15
@github-actions

github-actions Bot commented Oct 24, 2024

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                           Stmts    Miss  Cover    Missing
-------------------------------  -------  ------  -------  ---------
R/g_boxplot.R                        116     116  0.00%    147-310
R/g_correlationplot.R                137     137  0.00%    251-421
R/g_density_distribution_plot.R       86      86  0.00%    125-236
R/g_lineplot.R                       276     276  0.00%    266-611
R/g_scatterplot.R                    130     130  0.00%    142-310
R/g_spaghettiplot.R                  101     101  0.00%    248-381
R/geom_axes_line.R                   167     167  0.00%    46-358
R/t_summarytable.R                   102     102  0.00%    87-224
R/utils.R                             70      70  0.00%    17-137
TOTAL                               1185    1185  0.00%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 537a4c7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@donyunardi donyunardi self-assigned this Nov 12, 2024

@donyunardi donyunardi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry just got to this.

I re-ran the Schedule pipeline for r-hub workflow and it still failed because it wants nestcolor:
https://github.com/insightsengineering/goshawk/actions/runs/11787673893/job/32833413336

I think we should add nestcolor too? Osprey pipeline is failing as well for the same reason.
https://github.com/insightsengineering/osprey/actions/runs/11761956162/job/32764309495

@pawelru

pawelru commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

thanks for letting me know - I will push changes soon

@pawelru
pawelru marked this pull request as draft November 12, 2024 08:58
auto-merge was automatically disabled November 12, 2024 08:58

Pull request was converted to draft

@pawelru

pawelru commented Nov 12, 2024

Copy link
Copy Markdown
Contributor Author

noSuggests passed: https://github.com/insightsengineering/goshawk/actions/runs/11797719254/job/32862325239

There are other failures but that would require more thinking what's going on

@pawelru
pawelru marked this pull request as ready for review November 12, 2024 13:00
@pawelru
pawelru enabled auto-merge (squash) November 12, 2024 13:00

@donyunardi donyunardi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pawelru
pawelru merged commit 5ce8ecb into main Nov 12, 2024
@pawelru
pawelru deleted the add_rmarkdown branch November 12, 2024 22:07
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants