Skip to content

Conversation

@eanokian
Copy link
Contributor

This PR addresses #1056

@github-actions
Copy link
Contributor

github-actions bot commented Nov 24, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is good to go! Thanks for the fix! @shajoezhu ?

@eanokian
Copy link
Contributor Author

feel free to add @gmbecker as reviewer as well

@gmbecker
Copy link
Collaborator

@eanokian please "sign" the CLA per the instructions above

@eanokian
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@eanokian
Copy link
Contributor Author

Done, I have also fixed some linting issues. I think the GitHub workflow is waiting for a maintainer to approve the PR before triggering the R CMD check.

Copy link
Collaborator

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @eanokian , I will merge this in and run reverse dependency check

@shajoezhu shajoezhu merged commit f96f017 into insightsengineering:main Nov 26, 2025
28 of 29 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2025
@shajoezhu
Copy link
Collaborator

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants