Adding adqlqc dataset. #127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shajoezhu
approved these changes
Dec 16, 2022
Contributor
shajoezhu
left a comment
shajoezhu
left a comment
There was a problem hiding this comment.
lgtm! Thanks @ayogasekaram
Hi @nikolas-burkoff , just wondering if we need to make any other changes for this. Thanks a lot！
Contributor
|
I don't think there's anything else you need to do. BTW I'm assuming ADQLQC is a somewhat standard ADAM dataset - if not I wouldn't merge this and #128 should give users a better error message as to how to use this dataset in their own teal apps |
Contributor
|
Please add NEWS entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #122