Skip to content

Refactor a_count_values() #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shajoezhu merged 4 commits into from
Jan 17, 2025
Merged

Refactor a_count_values() #1374

shajoezhu merged 4 commits into from
Jan 17, 2025

Conversation

@edelarua
Copy link
Contributor

@edelarua edelarua commented Jan 16, 2025

Pull Request

Fixes #1373

@edelarua edelarua added the sme label Jan 16, 2025
@edelarua
Copy link
Contributor Author

edelarua commented Jan 16, 2025

@shajoezhu should this merge directly into your release PR branch (#1372)?

@edelarua edelarua requested a review from shajoezhu January 16, 2025 20:15
@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Unit Tests Summary

    1 files     84 suites   1m 19s ⏱️
  876 tests   864 ✅  12 💤 0 ❌
1 878 runs  1 181 ✅ 697 💤 0 ❌

Results for commit 7716f11.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 16, 2025 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
count_values 👶 $+0.07$ count_values_works_with_denom_specified

Results for commit 3130f0a

♻️ This comment has been updated with latest results.

@shajoezhu
Copy link
Contributor

shajoezhu commented Jan 17, 2025

Thanks a lot Em! Let me take a look now. main is fine. we can update that branch

@shajoezhu shajoezhu enabled auto-merge (squash) January 17, 2025 03:26
shajoezhu
shajoezhu approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @edelarua , this is fantatic!

@shajoezhu shajoezhu merged commit 296aeab into main Jan 17, 2025
28 checks passed
@shajoezhu shajoezhu deleted the 1373_refactor_count_values branch January 17, 2025 03:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
@Melkiades
Copy link
Contributor

Melkiades commented Jan 21, 2025

Pull Request

Fixes #1373

Very nice refactoring! I think we can actually retire make_afun!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

Assignees

No one assigned

Labels

sme

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor a_count_values()

4 participants

@edelarua @shajoezhu @Melkiades