Retire make_afun() - Batch 3

[edelarua]

Pull Request

Fixes #1383

Also disabled the lintr for long function names and removed the corresponding # nolint statements.

[github-actions]

Unit Tests Summary

    1 files     84 suites   1m 15s ⏱️
  876 tests   867 ✅   9 💤 0 ❌
1 882 runs  1 185 ✅ 697 💤 0 ❌

Results for commit 45f9a52.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
abnormal_by_worst_grade_worsen	💀	$0.70$	$-0.70$	$-20$	$-8$	$0$	$0$
abnormal_lab_worsen_by_baseline	👶		$+0.67$	$+20$	$+8$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
abnormal_by_worst_grade_worsen	💀	$0.40$	$-0.40$	count_abnormal_lab_worsen_by_baseline
abnormal_by_worst_grade_worsen	💀	$0.03$	$-0.03$	h_adlb_worsen_all_high
abnormal_by_worst_grade_worsen	💀	$0.02$	$-0.02$	h_adlb_worsen_all_low
abnormal_by_worst_grade_worsen	💀	$0.04$	$-0.04$	h_adlb_worsen_stacks_data_correctly
abnormal_by_worst_grade_worsen	💀	$0.11$	$-0.11$	h_adlb_worsen_stacks_data_correctly_simple_case_
abnormal_by_worst_grade_worsen	💀	$0.02$	$-0.02$	h_worsen_counter_counts_data_high_correctly
abnormal_by_worst_grade_worsen	💀	$0.02$	$-0.02$	h_worsen_counter_counts_data_low_correctly
abnormal_by_worst_grade_worsen	💀	$0.03$	$-0.03$	h_worsen_counter_counts_data_low_no_high_correctly
abnormal_by_worst_grade_worsen	💀	$0.02$	$-0.02$	h_worsen_counter_counts_data_low_no_low_correctly
abnormal_by_worst_grade_worsen	💀	$0.02$	$-0.02$	s_count_abnormal_lab_worsen_by_baseline
abnormal_lab_worsen_by_baseline	👶		$+0.38$	count_abnormal_lab_worsen_by_baseline
abnormal_lab_worsen_by_baseline	👶		$+0.03$	h_adlb_worsen_all_high
abnormal_lab_worsen_by_baseline	👶		$+0.02$	h_adlb_worsen_all_low
abnormal_lab_worsen_by_baseline	👶		$+0.03$	h_adlb_worsen_stacks_data_correctly
abnormal_lab_worsen_by_baseline	👶		$+0.11$	h_adlb_worsen_stacks_data_correctly_simple_case_
abnormal_lab_worsen_by_baseline	👶		$+0.02$	h_worsen_counter_counts_data_high_correctly
abnormal_lab_worsen_by_baseline	👶		$+0.02$	h_worsen_counter_counts_data_low_correctly
abnormal_lab_worsen_by_baseline	👶		$+0.02$	h_worsen_counter_counts_data_low_no_high_correctly
abnormal_lab_worsen_by_baseline	👶		$+0.02$	h_worsen_counter_counts_data_low_no_low_correctly
abnormal_lab_worsen_by_baseline	👶		$+0.02$	s_count_abnormal_lab_worsen_by_baseline

Results for commit f91894c

♻️ This comment has been updated with latest results.

[shajoezhu]

hi @edelarua , could you do a downstream test in scda.test, and lets make sure nothing breaks. thanks

[Melkiades]

Also disabled the lintr for long function names and removed the corresponding # nolint statements.

That is amazing! I was thinking that we need to change that since a bit. Thank you for taking action on that ;)

[Melkiades]

Lgtm! Great work Emily, Thanks

[edelarua]

All scda.test checks passing: insightsengineering/scda.test#184