Skip to content

Conversation

@danielinteractive
Copy link
Collaborator

@danielinteractive danielinteractive commented Dec 1, 2025

part of #1444

Also:

  • adds air.toml excluding the whole project from auto formatting when Air is used by developer
  • Updates my email address

@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@danielinteractive
Copy link
Collaborator Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks very very good!! Thanks @danielinteractive, it is practically ready. Only .gitignore, a couple of extra spaces, and the snapshots and it is good to go

@danielinteractive
Copy link
Collaborator Author

Thanks @Melkiades for your swift review, Air config files have been removed and the GHA checks are green now 👍

Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Thanks Daniel for the addition. Very clear code ;)

@danielinteractive
Copy link
Collaborator Author

Thanks @Melkiades , feel free to merge, I can't somehow 😄

@shajoezhu shajoezhu merged commit 342e3f0 into insightsengineering:main Dec 2, 2025
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
@danielinteractive danielinteractive deleted the 1444_prop_diff_test_alternative branch December 5, 2025 03:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants