-
-
Notifications
You must be signed in to change notification settings - Fork 29
1444: Added alternative argument to test_proportion_diff()
#1446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1444: Added alternative argument to test_proportion_diff()
#1446
Conversation
|
✅ All contributors have signed the CLA |
|
I have read the CLA Document and I hereby sign the CLA |
Melkiades
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks very very good!! Thanks @danielinteractive, it is practically ready. Only .gitignore, a couple of extra spaces, and the snapshots and it is good to go
|
Thanks @Melkiades for your swift review, Air config files have been removed and the GHA checks are green now 👍 |
Melkiades
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Thanks Daniel for the addition. Very clear code ;)
|
Thanks @Melkiades , feel free to merge, I can't somehow 😄 |
part of #1444
Also:
air.tomlexcluding the whole project from auto formatting whenAiris used by developer