Fix execute serialization compatibility with Selenium 2.x #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvorisek
commented
Apr 17, 2022
| // Potential compat-buster, i.e., W3C-specific | ||
| if ($value instanceof Element) { | ||
| $arguments[$key] = [Container::WEBDRIVER_ELEMENT_ID => $value->getID()]; | ||
| // preferably we want to detect W3C support and never set nor parse |
Contributor
Author
There was a problem hiding this comment.
is W3C support somehow reported & nicely detectable?
Member
There was a problem hiding this comment.
There was a w3c flag at one point but only on master. I'll need to revisit.
Member
|
Tagged. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#110 support is not working with Selenium 2.x as it does support only the legacy key.
Selenium 3.x is supporting both exclusively but also both together. Although Selenium 2.x does not support the W3C key, it does still acept both together.
I have no environment with the new Selenium 4.x by hand, but Selenium 2.x and 3.x accept the serialized element even when there is any other key present, thus I am quite confident Selenium 4.x will support also this compatibility solution with both keys passed.
This is a bugfix, please tag a new release once merged.