chore(config): fixed INSTANA_TRACING_DISABLE env var handling#2486
Merged
aryamohanan merged 2 commits intofix-config-precedencefrom Apr 13, 2026
Merged
chore(config): fixed INSTANA_TRACING_DISABLE env var handling#2486aryamohanan merged 2 commits intofix-config-precedencefrom
aryamohanan merged 2 commits intofix-config-precedencefrom
Conversation
aryamohanan
commented
Apr 13, 2026
aryamohanan
force-pushed
the
fix-config-test
branch
from
1bc8e73 to
2aedb69
Compare
aryamohanan
force-pushed
the
fix-config-precedence
branch
from
8ff6d41 to
7059a40
Compare
ProcessControls was setting INSTANA_TRACING_DISABLE=false for all tests where tracingEnabled=true (the default). According to the precedence rules in disable.js, when INSTANA_TRACING_DISABLE is set to 'false', it takes precedence over INSTANA_TRACING_DISABLE_INSTRUMENTATIONS and INSTANA_TRACING_DISABLE_GROUPS, preventing granular disable configurations from working in tests. This caused logging integration tests to fail when trying to disable specific instrumentations using INSTANA_TRACING_DISABLE_INSTRUMENTATIONS or INSTANA_TRACING_DISABLE_GROUPS. Changed ProcessControls to only set INSTANA_TRACING_DISABLE='true' when tracingEnabled=false, and not set it at all when tracingEnabled=true, allowing other disable environment variables to work correctly.
…olean Fixed normalizeTracingEnabled to only use INSTANA_TRACING_DISABLE for the tracing.enabled config when the env var value is 'true' or 'false'. When it contains instrumentation/group names (e.g., 'logging'), it's now handled by the separate disable normalizer
aryamohanan
force-pushed
the
fix-config-test
branch
from
2aedb69 to
8bd839c
Compare
aryamohanan
commented
Apr 13, 2026
|
|
||
| if (envDisableConfig !== null) { | ||
| if (envDisableConfig === true) { | ||
| logger?.debug('[config] env:INSTANA_TRACING_DISABLE = true'); |
Contributor
Author
There was a problem hiding this comment.
we already logged this, removed duplicate logging
|
24 tasks
abhilash-sivan
approved these changes
Apr 13, 2026
kirrg001
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two issues with how
INSTANA_TRACING_DISABLEwas handled:ProcessControls behavior
ProcessControlswas settingINSTANA_TRACING_DISABLE=falsefor all tests wheretracingEnabled=true(which is the default). Based on the precedence rules indisable.js, settingINSTANA_TRACING_DISABLEto'false'overridesINSTANA_TRACING_DISABLE_INSTRUMENTATIONSandINSTANA_TRACING_DISABLE_GROUPS, thereby blocking more granular disable configurations.This has been corrected so that
ProcessControlsnow setsINSTANA_TRACING_DISABLE='true'only whentracingEnabled=false, and leaves it unset whentracingEnabled=true.normalizeTracingEnabled fix
normalizeTracingEnabledhas been updated to considerINSTANA_TRACING_DISABLEfor thetracing.enabledconfiguration only when its value is'true'or'false'. If the variable contains instrumentation or group names (for example,'logging'), it is now handled separately by the disable normalizer.