refactor(config): replaced agentConfig usage with updated config#2507
Merged
aryamohanan merged 3 commits intofix-config-precedencefrom Apr 21, 2026
Merged
refactor(config): replaced agentConfig usage with updated config#2507aryamohanan merged 3 commits intofix-config-precedencefrom
aryamohanan merged 3 commits intofix-config-precedencefrom
Conversation
aryamohanan
changed the title
aryamohanan
changed the title
aryamohanan
changed the title
aryamohanan
changed the title
kirrg001
reviewed
Apr 21, 2026
| stackTraceLength = agentTraceConfig.stackTraceLength; | ||
| } | ||
| exports.activate = function activate(_config) { | ||
| stackTraceLength = _config.tracing?.stackTraceLength; |
Contributor
There was a problem hiding this comment.
Hm I see different approaches in active method.
if (_config.tracing.spanBatchingEnabled) {
batchingEnabled = true;
stackTraceLength = _config.tracing?.stackTraceLength;
```
kirrg001
approved these changes
Apr 21, 2026
32 tasks
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our codebase, agentConfig is used in several places such as spanBuffer and tracingUtil. This change replaces those usages.
We will also need to update the instrumentations, which will be addressed in a separate PR