chore: fixed failing config related tests#2508
Merged
aryamohanan merged 5 commits intofix-config-precedencefrom Apr 22, 2026
Merged
chore: fixed failing config related tests#2508aryamohanan merged 5 commits intofix-config-precedencefrom
aryamohanan merged 5 commits intofix-config-precedencefrom
Conversation
aryamohanan
changed the title
32 tasks
aryamohanan
changed the title
aryamohanan
commented
Apr 22, 2026
| } | ||
|
|
||
| if (rawValue !== undefined) { | ||
| logger?.warn(`[config] Validation failed for ${sourceKey}: ${JSON.stringify(rawValue)}`); |
Contributor
Author
There was a problem hiding this comment.
This log is not required and logging in general will be fixed in another PR
kirrg001
reviewed
Apr 22, 2026
| if (currentMeta && currentMeta.source < source) { | ||
| logger.debug(`[config] Skipping ${key}: current source ${currentMeta.source} > incoming ${source}`); | ||
| return currentConfig; | ||
| logger.debug(`[config] Skipping ${path}: current source ${currentMeta.source} > incoming ${source}`); |
Contributor
There was a problem hiding this comment.
Do we really need this log?
Contributor
Author
There was a problem hiding this comment.
Not really. We can examine and cleanup logs in a separate PR.
kirrg001
approved these changes
Apr 22, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.