feat(configuration): Mark 4xx calls as erroneous spans and adapt current instrumentations - #525
Merged
Conversation
CagriYonca
force-pushed
the
fix-4xx-code
branch
5 times, most recently
from
September 3, 2026 15:27
8caec8c to
aa5a672
Compare
pvital
requested changes
Sep 8, 2026
pvital
left a comment
pvital
left a comment
Member
There was a problem hiding this comment.
A few requests about the project pattern and structure. The implementation itself looks good.
@arjun-rajappa, please review my comments, as well as the entire PR.
arjun-rajappa
approved these changes
Sep 9, 2026
CagriYonca
force-pushed
the
fix-4xx-code
branch
3 times, most recently
from
September 9, 2026 15:07
5d6356e to
3413b73
Compare
CagriYonca
force-pushed
the
fix-4xx-code
branch
2 times, most recently
from
September 10, 2026 09:31
2e8fecd to
d4cbb26
Compare
CagriYonca
force-pushed
the
fix-4xx-code
branch
from
September 10, 2026 13:02
d4cbb26 to
6c84a4e
Compare
…ent instrumentations. Signed-off-by: Cagri Yonca <cagri@ibm.com>
CagriYonca
force-pushed
the
fix-4xx-code
branch
from
September 10, 2026 13:10
6c84a4e to
75434d1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a configurable option to mark HTTP 4xx responses as erroneous spans, and adapts the excon, net-http, and rest-client instrumentations to respect this setting.
Changes:
New http_4xx_as_error config option in config.rb
Instana::Util::Http helper for shared HTTP error classification logic
Updated excon and net-http instrumentation to use the new helper
Full test coverage across all affected instrumentations and the config/util layer