allow google oauth environment variables for self hosted - #2792
Conversation
📝 WalkthroughWalkthroughAdds optional Google OAuth configuration for the dashboard, including server-side validation, self-hosting deployment wiring, environment examples, and setup documentation with the required redirect URI. ChangesDashboard Google OAuth
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Checkov (3.3.8)self-hosting/docker-compose.local.ymlTraceback (most recent call last): self-hosting/docker-compose.with-caddy.ymlTraceback (most recent call last): self-hosting/docker-compose.ymlTraceback (most recent call last):
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
server/test/instant/config_test.clj (1)
6-28: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winCover the zero-arity path and startup validation.
These tests exercise only the two-argument helper, so they would still pass if environment lookup or the new
initvalidation call regressed. Add coverage for the zero-argument path and aninittest that verifies validation is invoked.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@server/test/instant/config_test.clj` around lines 6 - 28, Extend google-oauth-client-test to cover the zero-argument config/get-google-oauth-client path, preserving the existing fallback and override expectations. Add an init-focused test that verifies startup invokes the Google OAuth configuration validation, using the relevant init and validation symbols and stubbing dependencies as needed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@server/test/instant/config_test.clj`:
- Around line 6-28: Extend google-oauth-client-test to cover the zero-argument
config/get-google-oauth-client path, preserving the existing fallback and
override expectations. Add an init-focused test that verifies startup invokes
the Google OAuth configuration validation, using the relevant init and
validation symbols and stubbing dependencies as needed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 8f517eb8-963b-4a57-a709-81bfb2065fb1
📒 Files selected for processing (9)
client/www/app/docs/self-hosting/page.mdself-hosting/.env.exampleself-hosting/deploy-swarm.shself-hosting/docker-compose.local.ymlself-hosting/docker-compose.with-caddy.ymlself-hosting/docker-compose.ymlself-hosting/swarm.ymlserver/src/instant/config.cljserver/test/instant/config_test.clj
|
View Vercel preview at instant-www-js-drewh-google-oauth-self-hosted-jsv.vercel.app. |
tested e2e with a fresh google oauth pair and the docker-compose.local.yml file