Skip to content

Comments

[mmlu] Allow optionally setting a PyTorch device#62

Merged
danmcp merged 1 commit intoinstructlab:mainfrom
alinaryan:addDevice
Jul 11, 2024
Merged

[mmlu] Allow optionally setting a PyTorch device#62
danmcp merged 1 commit intoinstructlab:mainfrom
alinaryan:addDevice

Conversation

@alinaryan
Copy link
Contributor

@alinaryan alinaryan commented Jul 11, 2024

Gives the ability to optionally specify a PyTorch device when running MMLU and MMLUBranch, defaults to cpu.

Copy link
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. lets add this to the cli cfg, and as a flag to eval

@danmcp
Copy link
Contributor

danmcp commented Jul 11, 2024

Note this will need to be reworked with: https://github.com/instructlab/eval/pull/61/files

Signed-off-by: Alina Ryan <aliryan@redhat.com>
@alinaryan alinaryan changed the title [mmlu] Allow user to specify PyTorch device [mmlu] Allow optionally setting a PyTorch device Jul 11, 2024
Copy link
Contributor

@cdoern cdoern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. So basically its a option one can pass to the class and the defaulting that previously existed has been moved up to init

@danmcp danmcp merged commit 6041f91 into instructlab:main Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants