fix: catch KeyError in mt_bench_branch #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmcp
reviewed
Aug 1, 2024
bcrochet
force-pushed
the
catch-keyerror
branch
from
f025c6a to
4196ecd
Compare
danmcp
suggested changes
Aug 1, 2024
bcrochet
force-pushed
the
catch-keyerror
branch
from
4196ecd to
1822c35
Compare
danmcp
reviewed
Aug 1, 2024
If the keys for the questions and answers don't exist, the file should be ignored. Instead, it would currently crash with a stack trace. This will keep that from happening. Signed-off-by: Brad P. Crochet <brad@redhat.com>
bcrochet
force-pushed
the
catch-keyerror
branch
from
1822c35 to
a0c2bc8
Compare
danmcp
approved these changes
Aug 1, 2024
nathan-weinberg
approved these changes
Aug 1, 2024
alinaryan
approved these changes
Aug 1, 2024
booxter
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the keys for the questions and answers don't exist, the file should be ignored. Instead, it would currently crash with a stack trace. This will keep that from happening.