Skip to content
This repository was archived by the owner on Apr 23, 2026. It is now read-only.

add instructlab-training[hpu] to requirements/hpu.txt#2641

Merged
mergify[bot] merged 1 commit intoinstructlab:mainfrom
JamesKunstle:requirements-hpu
Nov 15, 2024
Merged

add instructlab-training[hpu] to requirements/hpu.txt#2641
mergify[bot] merged 1 commit intoinstructlab:mainfrom
JamesKunstle:requirements-hpu

Conversation

@JamesKunstle
Copy link
Copy Markdown
Contributor

in order for instructlab to be installed for hpus, require that we also
install the dependencies in the hpu set of requirements for
instructlab-training

Signed-off-by: James Kunstle jkunstle@redhat.com

Copy link
Copy Markdown
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding for instructlab/training#320 to merge

@nathan-weinberg nathan-weinberg added the hold In-progress PR. Tag should be removed before merge. label Nov 13, 2024
@mergify mergify Bot added the one-approval PR has one approval from a maintainer label Nov 13, 2024
Comment thread requirements/hpu.txt Outdated
#habana-torch-dataloader

# Extra dependencies for Intel Gaudi cards
instructlab-training[hpu]>=0.5.0
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should actually be held until 0.6.0 is cut and exists, since 0.6.0 will be the first version to feature the hpu extra

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the version here should actually be 0.6.0 instead of 0.5.0?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JamesKunstle please fix that when you get a chance, ty!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v0.6.0 has been cut now, so can be used as min

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it will update asap!

@JamesKunstle JamesKunstle removed the request for review from tiran November 15, 2024 18:42
@JamesKunstle
Copy link
Copy Markdown
Contributor Author

@Maxusmusti @nathan-weinberg Updated the PR to require training 0.6.0 as min bound for all extras

@nathan-weinberg nathan-weinberg removed the hold In-progress PR. Tag should be removed before merge. label Nov 15, 2024
in order for instructlab to be installed for hpus, require that we also
install the dependencies in the hpu set of requirements for
instructlab-training

Signed-off-by: James Kunstle <jkunstle@redhat.com>
@JamesKunstle
Copy link
Copy Markdown
Contributor Author

rebased to remove bumps to cuda and rocm extras from this commit

@mergify mergify Bot removed the one-approval PR has one approval from a maintainer label Nov 15, 2024
@mergify mergify Bot merged commit 61a9d7e into instructlab:main Nov 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Relates to dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants