deps: change hf accelerate bound, add requirements-hpu.txt#320
deps: change hf accelerate bound, add requirements-hpu.txt#320JamesKunstle merged 1 commit intoinstructlab:mainfrom
Conversation
|
Blocked because we probably need handling for DeepSpeed not being installed for ROCm and Gaudi: #291 |
3e38ed8 to
51dea40
Compare
3b2a9bc to
6198561
Compare
6198561 to
319cda0
Compare
|
Requires instructlab/instructlab#2641 |
| accelerate>=0.34.2 | ||
|
|
||
| # cuda, rocm, and hpu extras impose different lower-bounds on this library. | ||
| accelerate |
There was a problem hiding this comment.
the general overrides the extras requirements, so when this exists:
pip install instructlab-training: Requirement already satisfied: accelerate
pip install instructlab-training[cuda]: Requirement already satisfied: accelerate
when removed:
pip install instructlab-training: N/A
pip install instructlab-training[cuda]: Requirement already satisfied: accelerate>=0.34.2
There was a problem hiding this comment.
trl also has accelerate as a dependency as well, so just having trl>=0.9.4 in the requirements.txt makes sure general accelerate is pulled in.
From trl==0.9.4 requirements.txt:
datasets>=1.17.0
torch>=1.4.0
tqdm
transformers
accelerate
peft>=0.3.0
tyro>=0.5.7
There was a problem hiding this comment.
Requirement already satisfied: accelerate in .../lib64/python3.11/site-packages (from trl>=0.9.4->instructlab-training==0.6.0a1.dev7) (0.33.0)
Signed-off-by: James Kunstle <jkunstle@redhat.com>
319cda0 to
d4570ae
Compare
Adds
requirements-hpu.txtfile andoptional-dependencies.hputo pyproject.tomlSets lower bound for
acceleratefor rocm, cuda, and hpu separately.For HPU, sets
accelerate>=0.33.0becauseoptimum-habanarequires this.For CUDA/ROCm sets
accelerate=>0.34.2because accelerate got FSDP patches that we need.