[Student][MBL-13260] Fix non native quizzes from assignments#327
Merged
CalvinKern merged 1 commit intomasterfrom Oct 2, 2019
Merged
[Student][MBL-13260] Fix non native quizzes from assignments#327CalvinKern merged 1 commit intomasterfrom
CalvinKern merged 1 commit intomasterfrom
Conversation
|
Scan submitted to Checkmarx |
Checkmarx scan completedCheckmarx Scan Summary
Violation Summary
|
Codecov Report
@@ Coverage Diff @@
## master #327 +/- ##
============================================
+ Coverage 2.78% 10.37% +7.58%
- Complexity 174 724 +550
============================================
Files 437 449 +12
Lines 19044 21811 +2767
Branches 3479 3908 +429
============================================
+ Hits 531 2263 +1732
- Misses 18441 19238 +797
- Partials 72 310 +238 |
JordanMarshall
approved these changes
Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To test:
See ticket details, but basically any non native quiz was routing to the QuizStartFragment, which should only be navigated to if we have a native quiz. Otherwise, our BasicQuizViewFragment handles displaying quiz content that has web content.