[MBL-18767][Parent] Extend Student Alert Settings E2E test with mark below/above dependency testing #3580
Conversation
…lidation. refs: MBL-18767 affects: Parent release note:
…E-test-with-mark-below-above-dependency-testing
📊 Code Coverage Report✅ Student
✅ Teacher
✅ Pandautils
📈 Overall Average
|
🧪 Unit Test Results✅ 📱 Parent App
✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Wed, 18 Mar 2026 15:28:14 GMT |
|
Parent Install Page |
|
Student Install Page |
| @@ -442,4 +442,172 @@ class AlertsE2ETest : ParentComposeTest() { | |||
| alertsPage.assertAlertRead("Course grade: 90.0% in ${course.courseCode}") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I assumed this logic testing is just a few additional rows. Can't we merge this into the testAlertsE2E test's flow? I feel like a separate test case is kinda 'overkill' for this (another dataseeding, student, course, teacher, parent, etc.), unnecessarily. I can cope with this if you leave it as it is, I just wanted to make sure and double check if you thought about merging this into the existing case?
There was a problem hiding this comment.
I think it’s better to keep them separate rather than merging the two. The testAlertSettingsMarkBelowAboveDependencyE2E test is really focused on verifying that the dependency between below and above exists, and I think this way the behavior is tested more clearly and in more detail. If we merged them, the test would become robust for a single case i think.
adamNagy56
deleted the
MBL-18767-Extend-Student-Alert-Settings-E2E-test-with-mark-below-above-dependency-testing
branch
4 participants
Summary
Add E2E test for Student Alert Settings with below/above threshold validation.
refs: MBL-18767
affects: Parent
release note:
Checklist