Fix open source builds #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehoag
reviewed
Apr 4, 2019
| { | ||
| "client_info": { | ||
| "mobilesdk_app_id": "2", | ||
| "mobilesdk_app_id": "1:111111111111:android:1111111111111111", |
Contributor
There was a problem hiding this comment.
That's not a real id, is it?
Contributor
Author
There was a problem hiding this comment.
Google crashes unless the fake id matches a certain pattern. The id is still fake.
joehoag
approved these changes
Apr 4, 2019
This was referenced Oct 21, 2025
[MBL-19424][Teacher] Extend submission filtering with differentiation tags and custom statuses
#3310
Merged
kristofnemere
added a commit
that referenced
this pull request
Nov 24, 2025
Fixed multiple issues where ToDo list didn't automatically refresh after changes in various parts of the app: Changes: - ToDoListViewModel: Added CalendarSharedEvents listener to refresh on RefreshToDoList events - EditDashboardViewModel: Emit RefreshToDoList when favoriting/ unfavoriting courses to update filtered ToDo items - SubmissionWorker: Emit RefreshToDoList after successful assignment submissions to remove completed items This fixes the following QA findings from MBL-19553: - Issue #2: Badge updates but page doesn't refresh after creating events/todos - Issue #4: Favorite courses filter doesn't auto-update - Issue #5: Assignment submission doesn't refresh ToDo page - Issue #9: ToDo created from widget appears on widget but not page - Issue #10: Deleted event/ToDo doesn't disappear from page Test plan: - Create/update/delete calendar events and verify ToDo list refreshes - Favorite/unfavorite courses and verify filtered ToDos update - Submit assignments and verify they disappear from ToDo list - Create ToDos from widget and verify they appear in list - Delete events/ToDos and verify they disappear immediately 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
kristofnemere
added a commit
that referenced
this pull request
Nov 24, 2025
Fixed all test compilation errors caused by adding CalendarSharedEvents parameter to EditDashboardViewModel constructor. Changes: - Added CalendarSharedEvents import - Added calendarSharedEvents mock instance - Updated all 31 EditDashboardViewModel constructor calls to include the calendarSharedEvents parameter This ensures all existing tests continue to pass after adding the favorite courses refresh functionality (Issue #4). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.