Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix open source builds #4

Merged
merged 4 commits into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@bootstraponline
Copy link
Member

bootstraponline commented Apr 4, 2019

No description provided.

@@ -6,7 +6,7 @@
"client": [
{
"client_info": {
"mobilesdk_app_id": "2",
"mobilesdk_app_id": "1:111111111111:android:1111111111111111",

This comment has been minimized.

Copy link
@joehoag

joehoag Apr 4, 2019

Contributor

That's not a real id, is it?

This comment has been minimized.

Copy link
@bootstraponline

bootstraponline Apr 4, 2019

Author Member

Google crashes unless the fake id matches a certain pattern. The id is still fake.

@joehoag

joehoag approved these changes Apr 4, 2019

@bootstraponline bootstraponline merged commit 1924f6e into master Apr 4, 2019

4 checks passed

ci/bitrise/3875692b192c4eb3/pr Passed - Android Open Source Parent
Details
ci/bitrise/43a4503585e48423/pr Passed - Android Open Source Student
Details
ci/bitrise/758ed6bba9746be5/pr Passed - Android Open Source Teacher
Details
license/cla Contributor License Agreement is signed.
Details

@bootstraponline bootstraponline deleted the open_source branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.