[Student][Teacher][MBL-12193] Preview HTML files #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of downloading HTML files, preview them in a webview so that we can handle relative files that are referenced.
|
|
apps/student/src/main/java/com/instructure/student/router/RouteMatcher.kt
Outdated
Show resolved
Hide resolved
TrevorNeedham
suggested changes
Apr 8, 2019
Contributor
TrevorNeedham
left a comment
TrevorNeedham
left a comment
There was a problem hiding this comment.
Let's see if we can't de-dupe the logic for url construction like we chatted about.
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
========================================
Coverage 6.14% 6.14%
Complexity 91 91
========================================
Files 73 73
Lines 4427 4427
Branches 671 671
========================================
Hits 272 272
Misses 4115 4115
Partials 40 40 |
TrevorNeedham
approved these changes
Apr 8, 2019
kristofnemere
added a commit
that referenced
this pull request
Nov 24, 2025
Fixed multiple issues where ToDo list didn't automatically refresh after changes in various parts of the app: Changes: - ToDoListViewModel: Added CalendarSharedEvents listener to refresh on RefreshToDoList events - EditDashboardViewModel: Emit RefreshToDoList when favoriting/ unfavoriting courses to update filtered ToDo items - SubmissionWorker: Emit RefreshToDoList after successful assignment submissions to remove completed items This fixes the following QA findings from MBL-19553: - Issue #2: Badge updates but page doesn't refresh after creating events/todos - Issue #4: Favorite courses filter doesn't auto-update - Issue #5: Assignment submission doesn't refresh ToDo page - Issue #9: ToDo created from widget appears on widget but not page - Issue #10: Deleted event/ToDo doesn't disappear from page Test plan: - Create/update/delete calendar events and verify ToDo list refreshes - Favorite/unfavorite courses and verify filtered ToDos update - Submit assignments and verify they disappear from ToDo list - Create ToDos from widget and verify they appear in list - Delete events/ToDos and verify they disappear immediately 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of downloading HTML files, preview them in a webview so that we
can handle relative files that are referenced.
See Jira ticket for test plan.