Conversation
There was a problem hiding this comment.
Copilot reviewed 206 out of 216 changed files in this pull request and generated 1 comment.
Files not reviewed (10)
- lerna.json: Language not supported
- package.json: Language not supported
- packages/docs/package.json: Language not supported
- packages/examples/package.json: Language not supported
- packages/babel-plugin-transform-imports/package.json: Language not supported
- packages/browserslist-config-instui/package.json: Language not supported
- packages/canvas-high-contrast-theme/package.json: Language not supported
- packages/canvas-theme/package.json: Language not supported
- packages/command-utils/package.json: Language not supported
- packages/console/package.json: Language not supported
Comment on lines
+11
to
+12
| * **ui-alerts:** no passthroughProps are set in component so Alert won't pass down props such as id to the underlaying DOM ([e481373](https://github.com/instructure/instructure-ui/commit/e481373d1b16dc26f7c808e4ea31bd8c59e41883)) | ||
| * **ui-buttons:** fix button border color ([5322f9c](https://github.com/instructure/instructure-ui/commit/5322f9c8d359a394e0ea4caa5dbab982169edddf)) |
There was a problem hiding this comment.
Consider correcting the spelling from 'underlaying' to 'underlying'.
Suggested change
| * **ui-alerts:** no passthroughProps are set in component so Alert won't pass down props such as id to the underlaying DOM ([e481373](https://github.com/instructure/instructure-ui/commit/e481373d1b16dc26f7c808e4ea31bd8c59e41883)) | |
| * **ui-buttons:** fix button border color ([5322f9c](https://github.com/instructure/instructure-ui/commit/5322f9c8d359a394e0ea4caa5dbab982169edddf)) | |
| * **ui-alerts:** no passthroughProps are set in component so Alert won't pass down props such as id to the underlying DOM ([e481373](https://github.com/instructure/instructure-ui/commit/e481373d1b16dc26f7c808e4ea31bd8c59e41883)) |
|
ToMESSKa
approved these changes
Apr 11, 2025
balzss
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.