Conversation
|
Visual regression report
Diff images (1)link.png — 1691 pixels differBaselines come from the |
| #### Deprecated variant values | ||
|
|
There was a problem hiding this comment.
This was added by @git-nandor before the multi-versioning was introduced so I deleted this as I think the deprecation is not necessary and we can jump straight to removing these values.
| {name:"handleFocusOutlineColor",note:"only used by the removed deprecated thumb variant"}, | ||
| {name:"handleFocusOutlineWidth",note:"only used by the removed deprecated thumb variant"}, | ||
| {name:"handleShadowColor",note:"only used by the removed deprecated thumb variant"} |
There was a problem hiding this comment.
As the thumb variant was removed here #2544 but I realized these tokens should be removed as well so I updated this and told the designers to remove these tokens too.
|
|
||
| - `hideActionsUserSeparator` prop has been removed. |
There was a problem hiding this comment.
this prop was removed in the TopNavrBar rework #2512 because it was a fully 'dead' prop but I realized this was missing from the upgrade guide.
| // TODO: Remove this in v10! | ||
| if ('desktopConfig' in this.props) { |
There was a problem hiding this comment.
desktopConfig prop was removed in 2024 but this warning was left in, so I did not list desktopConfig in the upgrade guide as a removed prop.
BREAKING CHANGE: Removed FormFieldLabel component Removed _content prop from DrawerLayout.Tray and DrawerLayout.Content Removed _link prop from Link Removed _node prop from Menu.Item Removed _root prop from Pagination, TreeBrowser Removed _select prop from SimpleSelect and TimeSelect Removed _ref prop from TruncateText Removed _element prop from View Removed color="ai" from Heading Removed variant="inline-small" and variant="standalone-small" from Link Removed title prop from Tag Removed focusRingBorderRadius prop from View Removed hideActionsUserSeparator prop from TopNavBar.Layout Removed handleFocusOutlineColor, handleFocusOutlineWidth, handleShadowColor from RangeInput INSTUI-5025
ToMESSKa
force-pushed
the
INSTUI-5025-remove-deprecated-items-in-v-2
branch
from
874cb6c to
4340a2e
Compare
1 participant
BREAKING CHANGE:
Removed FormFieldLabel component
Removed _content prop from DrawerLayout.Tray and DrawerLayout.Content
Removed _link prop from Link
Removed _node prop from Menu.Item
Removed _root prop from Pagination, TreeBrowser
Removed _select prop from SimpleSelect and TimeSelect
Removed _ref prop from TruncateText
Removed _element prop from View
Removed color="ai" from Heading
Removed variant="inline-small" and variant="standalone-small" from Link
Removed title prop from Tag
Removed focusRingBorderRadius prop from View
Removed hideActionsUserSeparator prop from TopNavBar.Layout
Removed handleFocusOutlineColor, handleFocusOutlineWidth, handleShadowColor from RangeInput
INSTUI-5025
ISSUE:
TEST PLAN: