docs(many): fix default theme variables sections on component doc pages#2573
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
Visual regression report✅ No changes.
Baselines come from the |
f256daf to
8f72023
Compare
|
If I'm on v11.7 Alert and change from |
|
CloseButton displayed only 4 tokens on v10 and v11.6 but now displays much more. Is that on purpose? |
|
In v11.6 Modal.Body has one token in the canvas theme, but it does not have any tokens in the canvas-high-contrast theme? |
|
In Checkbox, v11.7, the Checkbox and the CheckboxFacade tabs have the same tokens, while in v11.6 and v10, the Checkbox tab has only 3 tokens? |
|
Pagination.PageInput has a 3 tokens displayed in v11.7, but it does not have any tokens displayed in v11.6. |
ToMESSKa
left a comment
There was a problem hiding this comment.
@git-nandor see my comments above
7e3bad3 to
a04f8e7
Compare
8f72023 to
a98af82
Compare
CloseButton/v1 exports its own generateComponentTheme, which contains only 4 tokens. After discussing it with Matyi, we decided that every component that borrows tokens will display a note explaining this behavior. |
CheckboxFacade: --> @withStyleNew(generateStyle, 'Checkbox') |
Nice catch, thanks! |
a98af82 to
14a00d3
Compare
a04f8e7 to
9618859
Compare
14a00d3 to
30e5d44
Compare
30e5d44 to
33b93b0
Compare
ToMESSKa
left a comment
There was a problem hiding this comment.
Looks good for me, nice work!

INSTUI-5045
Summary
Fixes the "Default Theme Variables" section on docs pages. The build script now generates theme data for all themes, and components that reuse another component's tokens are correctly linked to their theme, allowing the docs to display the right theme variables.
Test plan
Button,IconButton,CondensedButton,CloseButton— borrowBaseButtontokens viauseTokensFromModal.Header,Modal.Body,Modal.Footer— child tabs of compoundModalDrilldown.Group— YAML frontmatterthemeId: OptionsoverrideCheckboxFacade,ToggleFacade— point toCheckbox/ToggleTreeBrowser.Button,TreeBrowser.Collection,TreeBrowser.Node— all shareTreeBrowserTreeButtonTopNavBar.Brand,TopNavBar.Item,TopNavBar.MenuItems,TopNavBar.ActionItems,TopNavBarDesktopLayout,TopNavBarSmallViewportLayout— borrowTopNavBarLayoutNumberInput— functional component withuseTokensFrom: 'TextInput'(manualthemeIdattachment)Menu.Separator— props-free child; theme section still rendersPagination.PageInput,SideNavBar.Item— borrowed-token edge casesCo-Authored-By: 🤖 Claude