Aiinfo diffcache #104
Merged
Aiinfo diffcache #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tructure.ai into aiinfo-diffcache
…tructure.ai into aiinfo-diffcache
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the aiinfo package version and replaces the deprecated vite-node loader with a custom ES module loader for handling TypeScript files in CI/CD workflows.
- Updates aiinfo package version from 1.2.2 to 1.2.4
- Introduces a custom ES module loader to replace deprecated vite-node loader
- Adds
--no-git-checksflag to all pnpm publish commands in the release workflow
Reviewed Changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/loader.mjs | Adds custom ES module loader for TypeScript file transformation |
| packages/aiinfo/package.json | Bumps package version from 1.2.2 to 1.2.4 |
| .github/workflows/release-package.yml | Updates loader configuration and adds git check bypass flags |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| # NOW enable vite-node loader so any .ts/.mts imports work everywhere below | ||
| export NODE_OPTIONS="--loader=${{ github.workspace }}/scripts/loader.mjs" | ||
| # NOW enable vite-node loader using the new register() API | ||
| export NODE_OPTIONS="--import='data:text/javascript,import { register } from \"node:module\"; import { pathToFileURL } from \"node:url\"; register(\"${{ github.workspace }}/scripts/loader.mjs\", pathToFileURL(\"./\"));'" |
There was a problem hiding this comment.
[nitpick] The inline JavaScript code in NODE_OPTIONS is complex and hard to read. Consider creating a separate bootstrap script file that handles the loader registration, which would improve readability and maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.