Handle non-zip files correctly#10
Merged
abutterf merged 1 commit intoinstructure:masterfrom Mar 17, 2015
Merged
Conversation
lib/scorm_cloud/course_service.rb
Outdated
There was a problem hiding this comment.
So I guess the ordering of this just doesn't make logical sense to me. First we check whether the zip file is an invalid scorm package and then we check whether the zip file is really a zip file. Is there a good reason we are doing things this way?
Author
There was a problem hiding this comment.
Not particularly - I just discovered the checks that were needed in that order. The checks could be ordered either way. I'm fine reordering them if you think it'd make more logical sense.
javawizard
force-pushed
the
non-zip-files
branch
from
9d62721 to
bb51ce0
Compare
|
Looks good to me |
abutterf
pushed a commit
that referenced
this pull request
Mar 17, 2015
Handle non-zip files correctly round 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.