Skip to content

Cam qc explicit #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mayofaulkner merged 3 commits into from
Nov 24, 2022
Merged

Cam qc explicit #541

mayofaulkner merged 3 commits into from
Nov 24, 2022

Conversation

@juhuntenburg
Copy link
Contributor

@juhuntenburg juhuntenburg commented Nov 23, 2022

  • Changes Camera and DLC QC so that the extended qc json will contain the outcome as string (PASS, WARNING, FAIL, NOT_SET) instead of reducing to a boolean
  • Also adapts the threshold for the pin_state check so that a difference of up to 5 in TTL fronts still counts as passing

Example session on which this version of the code has been used to compute video and dlc QC:
https://alyx.internationalbrainlab.org/admin/actions/session/58ab6dfd-a0bf-4d2e-9ab7-11de6b6a3ca8/change/?_changelist_filters=q%3D58ab6dfd-a0bf-4d2e-9ab7-11de6b6a3ca8

@juhuntenburg juhuntenburg reopened this Nov 23, 2022
@mayofaulkner mayofaulkner merged commit 0289996 into develop Nov 24, 2022
@k1o0 k1o0 deleted the cam_qc_explicit branch September 19, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@juhuntenburg @mayofaulkner