Skip to content

Conversation

@chris-langfield
Copy link
Contributor

@chris-langfield chris-langfield commented Jun 21, 2023

From the discussion in int-brain-lab/ibl-neuropixel#13 we are going to move bincount2D to iblutil.

This replaces brainbox.processing.bincount2D with a call to the imported version from iblutil and adds a warning.

Also updates the requirements to iblutil 1.6.1, which contains the replaced method. (int-brain-lab/iblutil#19)

Copy link
Contributor

@k1o0 k1o0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just change the requirements to a minor release. For the other rigs I've been raising both a DeprecationWarning and a logger warning in case users turn off the ibllib logger but that's overkill to be honest. We also usually include a print statement of the traceback because it's sometime very difficult to find the call to that function, like this:

for line in traceback.format_stack():
print(line.strip())

It's also super annoying though (which may be a good thing). Personally I don't think it's particularly necessary.

Finally, Olivier adds something that breaks the test as a reminder to remove the deprecated function e.g. 2f6a13e. I just set a reminder in Slack once the branch has been merged for release.

@k1o0 k1o0 changed the base branch from master to develop June 27, 2023 18:01
@chris-langfield
Copy link
Contributor Author

New branch

@k1o0 k1o0 deleted the move_bincount2D branch September 19, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants