Skip to content

Conversation

@k1o0
Copy link
Contributor

@k1o0 k1o0 commented Jun 26, 2023

  • deprecated velocity, velocity_smothed, and last_movement_onset
  • get_movement_onset function
  • updated wheel documentation

NB: Replacing velocity_smoothed with velocity_filtered in the wheel alignment code significantly changes the cross correlation output. We'll need to check if it's an improvement.

k1o0 added 4 commits June 20, 2023 12:24
* Fix issue with trials and training table merge; clarify use of SessionLoader
…vement_onset function; update wheel documentation
@CodyCBakerPhD
Copy link

Just curious - what is the reason for deprecating those functions?

We ran them and included the one-off output in the NWB version of the initial BWM release - are you recommending we remove it from there as well?

@k1o0
Copy link
Contributor Author

k1o0 commented Jun 27, 2023

Just curious - what is the reason for deprecating those functions?

We ran them and included the one-off output in the NWB version of the initial BWM release - are you recommending we remove it from there as well?

The velocity function was never really used by us (sorry for the miscommunication on that). It simply returns the diff of the wheel position. To reduce noise caused by imprecision in the recording, we filter the signal. We'd advise against using the unfiltered velocity for analysis.

unnamed
*The green line represents the output of velocity_filtered.

If possible, it would be worth replacing the velocity with the filtered velocity version in the data.

@k1o0 k1o0 merged commit 8a9bae3 into develop Jul 12, 2023
@k1o0 k1o0 deleted the wheelDeprecations branch July 12, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants