Define intake.drivers entrypoints.#43
Conversation
|
Is there any way to test this? Perhaps that the initial Intake import does not issue the FutureWarning. |
|
That's a good idea. We would need a version of intake that issues that |
|
I see this now: |
|
I see that on intake |
|
That is probably intentional :) We should probably have nightly builds on intake/intake which tests master against the most important driver packages... |
|
Right, agree. We have a bit of a chicken-and-egg problem here: it would be nice to update the most important driver packages before pushing the next intake release out to spare users that How about I add a test that maybe skipped conditional on a version check with intake, confirm it passes locally against |
|
Perfect |
Another way to do this is to set up nightly builds on each important downstream project that tests against intake |
|
Hm, it depends on whether we expect the maintainers of the individual packages to notice (in possibly a number of places), or if only Intake maintainers get notified, and then need to inform others about possible upcoming issues. So long as it's only me, I'd prefer to keep things in one place, but I hope not to be main/only maintainer for long! |
7da71f7 to
f63499c
Compare
|
That's a reasonable position. And there's no reason we can't take both approaches. |
|
Back to the topic of this PR: I pushed a commit adding a test. I wasn't thinking clearly earlier when I suggested a version check / skip-test approach. It's sufficient to assert that no |
|
OK, fair enough. Thanks for doing this. |
This PR adds support for the new driver discovery mechanism added in intake/intake#236. It does not change the behavior of intake-xarray with older versions of intake.