feat(private-spaces): add private spaces endpoints, tools and organization field (ORB-1919) - #74
Merged
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…RB-1919) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…1919) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…rved (ORB-1919) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…es with live API (ORB-1919) Live smoke test against eu2.make.com showed consumedCenticredits is serialized as a string on every route, and transferLimit as a string on list/get but a number on the update response — both diverging from the OpenAPI spec's integer/string declarations. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JanKulhavy
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class Private Spaces support to the Make TypeScript SDK, including endpoint methods, MCP tool definitions, tests/mocks, and minimal related typing/docs updates.
Changes:
- Introduces
PrivateSpacesendpoint (list,get,update) and wires it intoMake, public type exports, and tools aggregation. - Adds MCP tool definitions for private-spaces operations and corresponding tool/unit tests + mocks.
- Extends
Organizationtyping/mocks to include theprivateSpacescolumn and updates README endpoint/tool category lists.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/private-spaces.spec.ts | Unit tests for privateSpaces.list/get/update URL/query/body behavior. |
| test/private-spaces.integration.test.ts | Integration coverage for listing/getting/updating and restoring operations limits. |
| test/private-spaces-tools.spec.ts | Validates MCP tool registration and execution for private-spaces tools. |
| test/organizations.spec.ts | Adds coverage for requesting privateSpaces via organization cols. |
| test/mocks/private-spaces/update.json | Mock response for private-space update. |
| test/mocks/private-spaces/list.json | Mock response for listing private spaces. |
| test/mocks/private-spaces/get.json | Mock response for getting a private space (including usage totals). |
| test/mocks/organizations/get.json | Adds privateSpaces field to organization get mock. |
| src/tools.ts | Registers private-spaces tool definitions in MakeTools. |
| src/make.ts | Adds make.privateSpaces endpoint property initialization and JSDoc. |
| src/index.ts | Exports private-spaces-related public types. |
| src/endpoints/private-spaces.ts | Implements PrivateSpaces endpoint + types and response shapes. |
| src/endpoints/private-spaces.tools.ts | Adds MCP tool definitions for private-spaces list/get/update. |
| src/endpoints/organizations.ts | Extends Organization type with privateSpaces column shape. |
| README.md | Documents the new endpoint and tool category. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- (r3658325414) private-spaces.integration.test.ts: skip restore when either original limit or consumption is unobserved (&& -> ||), and only send confirmed:true when the restored limit is below consumption - (r3658325454) private-spaces.tools.ts: mark private-spaces_update with destructiveHint:true — it can lower limits and pause a space, matching the repo convention for update tools Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
- integration test: try/finally guarantees limit restore even when the post-update assertion fails (live, billing-relevant state) - integration test: prefer the caller's own space via users.me() (get() 404s for non-members; update() mutates live state) - tools: fix misleading update example — confirmed:true now paired with a below-consumption limit, null-limit example standalone - mocks: realistic list.json shape (limits/consumption incl. string transferLimit/consumedCenticredits); organizations list mock now round-trips the privateSpaces column - tools spec: cover externalId filter and null-limit/no-confirm branches Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
JanKulhavy
marked this pull request as ready for review
July 27, 2026 15:30
Uğur Oruç (Ketcap)
approved these changes
Jul 28, 2026
2 tasks
Uğur Oruç (Ketcap)
added a commit
that referenced
this pull request
Jul 28, 2026
[AI code generation] ## Summary - Bump version to 1.6.6 for release. Changes since v1.6.5: - feat(private-spaces): add private spaces endpoints, tools and organization field (ORB-1919) (#74) ## Test plan - [x] `npm run lint` passes (`tsc` + `eslint`) - [x] `npx prettier --check` passes on changed files (package.json, package-lock.json)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds first-class Private Spaces support to the Make TypeScript SDK, including endpoint methods, MCP tool definitions, tests/mocks, and minimal related typing/docs updates.
https://make.atlassian.net/browse/ORB-1919