forked from davisagli/SublimePythonCoverage
-
Notifications
You must be signed in to change notification settings - Fork 5
Sublime text 3 rewrite and new features #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verage. The Simplecov package for the Atom editor uses this format. By using it here, we can support teams who use both editors without requiring them to use multiple formatters.
|
As I have not heard back on this, I will submit my package to Package Control separately. |
|
This is awesome! We aren't maintaining this anymore, so I'm happy to see someone else take over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @iamruinous et al,
I spent my weekend at Rails Camp 17 just north of Sydney, Australia re-writing this package for Sublime Text 3, making it generally easier on the eye and adding a number of additional features. This pull request is the culmination of that work.
Here’s a glance at what it looks like:
An overview of the changes:
This is a full rewrite. Essentially nothing of the original code survives.
Since the rewrite I am contributing here works only on Sublime Text 3, my plan would be to publish a Package Control manifest keeping the previous version of the package (with maintenance to happen as required on a branch) available for ST2 users, and making the new version available for ST3 users.
Given that this package has not been updated in over two years, I am operating under the assumption that it is no longer being actively maintained. I would like to volunteer to take over active maintenance of and support for this package. I’m happy just to be added as a contributor to the intergrum/SublimeRubyCoverage repository for now so that I can handle the release of this new version, but in time (assuming Integrum will no longer be maintaining this package) I think it would make sense to move it over to my GitHub account (with the appropriate repository move added to Package Control, so users are auto-upgraded).
Please do not simply merge this to master, since it will break the package for current ST2 users who are using it. Rather, let me know if you’re happy to add me as a maintainer, and I’ll take care of performing an orderly release of the new version while keeping the old version available for ST2 users.
I look forward to hearing from you! 😄