You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
CodeQL alert #116 identifies an incomplete URL substring assertion in apps/desktop/src/credential-service.test.ts around line 711. The test currently uses startsWith('https://attacker.example.test'), which can accept a lookalike hostname such as attacker.example.test.evil.invalid.
Make the narrow test-only correction on the desktop UX subepic branch:
Parse the captured request URL and assert the exact canonical origin/hostname and expected pathname/query rather than a string prefix.
Retain the test's main-only bearer/no-cookie, active scope, generation, rejection, and request-count assertions.
Add/retain an explicit negative lookalike-host case so attacker.example.test.evil.invalid cannot satisfy the assertion.
Do not change production credential behavior, transport authorization, current-user acceptance counts, workflow files, package-lock.json, visual geometry, or platform matrices.
Run the focused credential-service tests, desktop typecheck, relevant lint/CodeQL-compatible analysis, and git diff --check.
CodeQL alert #116 identifies an incomplete URL substring assertion in apps/desktop/src/credential-service.test.ts around line 711. The test currently uses startsWith('https://attacker.example.test'), which can accept a lookalike hostname such as attacker.example.test.evil.invalid.
Make the narrow test-only correction on the desktop UX subepic branch:
This is platform-neutral cleanup for the macOS/Linux release; Windows remains deferred to #2074.