fix auto_scheme gguf format wrong bits if use tiny model#1953
Merged
Conversation
Signed-off-by: n1ck-guo <heng.guo@intel.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes AutoScheme’s bit-budget accounting for tiny models when using GGUF-related options by ensuring embedding layers remain eligible for scheme assignment (even after they’re removed from the DP scoring layer list) and by applying the lm_head “head trick” after embedding-layer budget has been deducted.
Changes:
- Fix embedding eligibility computation so embedding layers are assigned an AutoScheme option even though they’re removed from
quant_layer_namesfor DP scoring. - Move the lm_head option restriction (
_apply_head_trick) to run after embedding-layer scheme selection so feasibility/budget checks use the true remaining budget. - Refactor embedding eligibility into a helper and update lm_head rule comments.
Signed-off-by: n1ck-guo <heng.guo@intel.com>
wenhuach21
reviewed
Jun 25, 2026
Contributor
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: n1ck-guo <heng.guo@intel.com>
wenhuach21
reviewed
Jun 26, 2026
Contributor
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: n1ck-guo <heng.guo@intel.com>
Contributor
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…round into hengguo/gguf_fix_625
Contributor
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Unit-Test-CUDA-AutoRound |
|
Azure Pipelines successfully started running 1 pipeline(s). |
xin3he
approved these changes
Jun 29, 2026
XuehaoSun
approved these changes
Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please briefly describe your main changes, the motivation.
Type of Change
Bug fix
Related Issues
Fixes or relates to #
Checklist Before Submitting
/azp run Unit-Test-CUDA-AutoRound.