Skip to content

rename the base rotation (deterministic/random hadamard) directory name.#1956

Merged
chensuyue merged 2 commits into
intel:mainfrom
lkk12014402:rename_base_rotation
Jul 2, 2026
Merged

rename the base rotation (deterministic/random hadamard) directory name.#1956
chensuyue merged 2 commits into
intel:mainfrom
lkk12014402:rename_base_rotation

Conversation

@lkk12014402

@lkk12014402 lkk12014402 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Description

Directory What the name implies What the directory actually contains
quarot/ the QuaRot algorithm not QuaRot — it is per-Linear Hadamard (registered as "hadamard")
spinquant/ only SpinQuant both SpinQuant and QuaRot (QuaRot = the non-trainable variant of SpinQuant)

After the rename

Directory Contents Registered name
hadamard/ per-Linear Hadamard rotation "hadamard/random_hadamard"
spinquant/ shared R1–R4 implementation for SpinQuant (trainable) + QuaRot (non-trainable) "spinquant" / "quarot"

The directory name hadamard/ now matches its registered name "hadamard" and
is no longer misleading.

Signed-off-by: lkk12014402 <kaokao.lv@intel.com>
@lkk12014402 lkk12014402 requested a review from n1ck-guo June 26, 2026 07:08
@lkk12014402

Copy link
Copy Markdown
Contributor Author

@n1ck-guo please help review~

@chensuyue chensuyue added this to the 0.14.0 milestone Jun 26, 2026
@n1ck-guo

Copy link
Copy Markdown
Contributor

LGTM @wenhuach21 any comment?

@wenhuach21

Copy link
Copy Markdown
Contributor

looks good to me.
1 From an algorithm perspective, however, Quarot is more accurate regardless of whether rotation is fused or not.

2 The rotation documentation should also be refined. It contains too much low-level detail that most users won't understand. It would be better to keep the main documentation concise and move the implementation details to a separate section (or collapse them under a "Details" section).

@lkk12014402

Copy link
Copy Markdown
Contributor Author

looks good to me. 1 From an algorithm perspective, however, Quarot is more accurate regardless of whether rotation is fused or not.

2 The rotation documentation should also be refined. It contains too much low-level detail that most users won't understand. It would be better to keep the main documentation concise and move the implementation details to a separate section (or collapse them under a "Details" section).

okay

@lkk12014402

Copy link
Copy Markdown
Contributor Author

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@chensuyue

Copy link
Copy Markdown
Contributor

/azp run Unit-Test-CUDA-AutoRound

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@chensuyue chensuyue merged commit 45dcb19 into intel:main Jul 2, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants