enabling actions#260
Closed
ArturHarasimiuk wants to merge 8 commits into
Closed
Conversation
ArturHarasimiuk
added a commit
to ArturHarasimiuk/compute-runtime
that referenced
this pull request
Feb 20, 2020
intel#260 Change-Id: Ie04607e5a6f69966e19effb436a31c1de0dd585c Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
ArturHarasimiuk
added a commit
to ArturHarasimiuk/compute-runtime
that referenced
this pull request
Feb 20, 2020
intel#260 Change-Id: Ie04607e5a6f69966e19effb436a31c1de0dd585c Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
ArturHarasimiuk
force-pushed
the
actions
branch
from
d1a7fe9 to
f27570d
Compare
ArturHarasimiuk
added a commit
to ArturHarasimiuk/compute-runtime
that referenced
this pull request
Feb 20, 2020
intel#260 Change-Id: Ie04607e5a6f69966e19effb436a31c1de0dd585c Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
ArturHarasimiuk
force-pushed
the
actions
branch
from
f27570d to
151b599
Compare
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
Hi there,
Feel free to ignore my comments, I'm just curious about GitHub actions by myself (example) and interested in review workflows in other projects to find some ideas or more examples
| matrix: | ||
| compiler: [gcc-5, gcc-6, gcc-7, gcc-8] | ||
| env: | ||
| WORKFLOW: CI |
There was a problem hiding this comment.
Suggested change
| WORKFLOW: CI | |
| WORKFLOW: ${{ github.workflow}} |
? Just to unify this line across different workflows
| env: | ||
| BUILD_OS: ubuntu-18.04 | ||
| COMPILER: ${{ matrix.compiler }} | ||
| run: ./neo/scripts/actions/run-action-build.sh |
There was a problem hiding this comment.
I guess this should launch a different script, right?
Would it be better to just express it via separate job in the CI workflow?
| BUILD_OS: ubuntu-18.04 | ||
| COMPILER: ${{ matrix.compiler }} | ||
| working-directory: neo/scripts/actions | ||
| run: ./run-action-docker-prepare.sh |
There was a problem hiding this comment.
What about using steps.with, or steps.with.args? (docs) - it will clearly indicate which env variables are actually used and should be treated as arguments for the particular step
Panquesito7
suggested changes
Feb 19, 2021
Panquesito7
left a comment
Panquesito7
left a comment
There was a problem hiding this comment.
I think you should also disable Travis CI, as GitHub Actions works much faster than Travis CI.
Comment on lines
+2
to
+11
| on: | ||
| push: | ||
| branches: | ||
| - master |
There was a problem hiding this comment.
Suggested change
| on: | |
| push: | |
| branches: | |
| - master | |
| on: [push] |
| @@ -0,0 +1,27 @@ | |||
| #!/bin/bash -x | |||
| # | |||
| # Copyright (C) 2020 Intel Corporation | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2020 Intel Corporation | |
| # Copyright (C) 2021 Intel Corporation |
| @@ -0,0 +1,21 @@ | |||
| #!/bin/bash | |||
| # | |||
| # Copyright (C) 2020 Intel Corporation | |||
There was a problem hiding this comment.
Suggested change
| # Copyright (C) 2020 Intel Corporation | |
| # Copyright (C) 2021 Intel Corporation |
ArturHarasimiuk
force-pushed
the
actions
branch
5 times, most recently
from
e406d7a to
10101ca
Compare
Signed-off-by: Artur Harasimiuk <artur.harasimiuk@intel.com>
ArturHarasimiuk
force-pushed
the
actions
branch
from
10101ca to
adb896e
Compare
ArturHarasimiuk
force-pushed
the
actions
branch
from
5404e02 to
be4b773
Compare
Contributor
|
closing as deprecated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Harasimiuk artur.harasimiuk@intel.com