🐛 Fix bug in fetch_and mutation test - #137
Merged
Merged
Conversation
Problem: - The test for `fetch_and` can complete with one of the test values being zero in the case where the operations happened one way around. This is not a problem, but the same outcome can be produced by a mutation test replacing `+=` with `-=`. Solution: - Alter the test values so that zero is not a possible outcome. Changing `+=` to `-=` will produce a mutation that does not survive.
elbeno
enabled auto-merge
July 14, 2026 13:14
bdeane-intel
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
fetch_andcan complete with one of the test values being zero in the case where the operations happened one way around. This is not a problem, but the same outcome can be produced by a mutation test replacing+=with-=.Solution:
+=to-=will produce a mutation that does not survive.