Skip to content

🚨 Relax google-explicit-constructor lint directives #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elbeno merged 1 commit into from
Jul 6, 2026
Merged

🚨 Relax google-explicit-constructor lint directives #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions include/stdx/ct_string.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ concept format_convertible = requires(T t) {
template <std::size_t N> struct ct_string {
consteval ct_string() = default;

// NOLINTNEXTLINE(*-avoid-c-arrays, google-explicit-constructor)
// NOLINTNEXTLINE(*-avoid-c-arrays)
consteval explicit(false) ct_string(char const (&str)[N]) {
for (auto i = std::size_t{}; i < N; ++i) {
// NOLINTNEXTLINE(cppcoreguidelines-pro-bounds-*)
Expand All @@ -36,7 +36,6 @@ template <std::size_t N> struct ct_string {
}

template <detail::format_convertible T>
// NOLINTNEXTLINE(google-explicit-constructor)
consteval explicit(false) ct_string(T t) : ct_string(+t) {}

consteval explicit(true) ct_string(char const *str, std::size_t sz) {
Expand Down
6 changes: 2 additions & 4 deletions include/stdx/env.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,17 +44,15 @@ concept envlike = is_specialization_of_v<T, env>;

namespace _env {
template <typename T> struct autowrap {
// NOLINTNEXTLINE(google-explicit-constructor)
consteval autowrap(T t) : value(t) {}
consteval explicit(false) autowrap(T t) : value(t) {}
T value;
};

// NOLINTNEXTLINE(*-avoid-c-arrays)
template <std::size_t N> using str_lit_t = char const (&)[N];

template <std::size_t N> struct autowrap<str_lit_t<N>> {
// NOLINTNEXTLINE(google-explicit-constructor)
consteval autowrap(str_lit_t<N> str) : value(str) {}
consteval explicit(false) autowrap(str_lit_t<N> str) : value(str) {}
stdx::ct_string<N> value;
};

Expand Down
13 changes: 5 additions & 8 deletions include/stdx/span.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,16 +93,15 @@ class span : public detail::span_base<T, Extent> {
: base_t{first, sore}, ptr{stdx::to_address(first)} {}

template <typename U, std::size_t N>
// NOLINTNEXTLINE(google-explicit-constructor)
constexpr span(std::array<U, N> &arr LIFETIMEBOUND) noexcept
constexpr explicit(false) span(std::array<U, N> &arr LIFETIMEBOUND) noexcept
: base_t{std::data(arr), N}, ptr{std::data(arr)} {
static_assert(Extent == dynamic_extent or Extent <= N,
"Span extends beyond available storage");
}

template <typename U, std::size_t N>
// NOLINTNEXTLINE(google-explicit-constructor)
constexpr span(std::array<U, N> const &arr LIFETIMEBOUND) noexcept
constexpr explicit(false)
span(std::array<U, N> const &arr LIFETIMEBOUND) noexcept
: base_t{std::data(arr), N}, ptr{std::data(arr)} {
static_assert(Extent == dynamic_extent or Extent <= N,
"Span extends beyond available storage");
Expand All @@ -112,8 +111,7 @@ class span : public detail::span_base<T, Extent> {
template <std::size_t N> using arr_t = type_identity_t<element_type> (&)[N];

template <std::size_t N>
// NOLINTNEXTLINE(google-explicit-constructor)
constexpr span(arr_t<N> arr LIFETIMEBOUND) noexcept
constexpr explicit(false) span(arr_t<N> arr LIFETIMEBOUND) noexcept
: base_t{std::data(arr), N}, ptr{std::data(arr)} {
static_assert(Extent == dynamic_extent or Extent <= N,
"Span extends beyond available storage");
Expand All @@ -136,8 +134,7 @@ class span : public detail::span_base<T, Extent> {

template <class U, std::size_t N>
requires(dependent_extent<U> == dynamic_extent or N != dynamic_extent)
// NOLINTNEXTLINE(google-explicit-constructor)
constexpr span(span<U, N> const &s) noexcept
constexpr explicit(false) span(span<U, N> const &s) noexcept
: base_t{s.data(), s.size()}, ptr{s.data()} {}

[[nodiscard]] constexpr auto data() const noexcept -> pointer {
Expand Down
9 changes: 3 additions & 6 deletions include/stdx/utility.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,8 @@ template <char... Chars> consteval auto operator""_z64() {

namespace cxv_detail {
struct from_any {
// NOLINTNEXTLINE(google-explicit-constructor)
template <typename... Ts> constexpr from_any(Ts const &...) {}
// NOLINTNEXTLINE(google-explicit-constructor)
constexpr operator int() const { return 0; }
template <typename... Ts>
constexpr explicit(false) from_any(Ts const &...) {}
};

struct value_marker {};
Expand Down Expand Up @@ -252,8 +250,7 @@ constexpr auto is_aligned_with = [](auto v) -> bool {

namespace detail {
template <typename T> struct ct_helper {
// NOLINTNEXTLINE(google-explicit-constructor)
consteval ct_helper(auto t) : value(t) {}
consteval explicit(false) ct_helper(auto t) : value(t) {}
T value;
};

Expand Down