Skip to content

Upgrade perf to base on Linux 5.18 #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2022
Merged

Upgrade perf to base on Linux 5.18 #411

merged 2 commits into from
Jul 24, 2022

Conversation

@Jongy
Copy link
Contributor

@Jongy Jongy commented Jul 18, 2022

No description provided.

@Jongy Jongy requested a review from michelhe July 18, 2022 11:39
@Jongy
Copy link
Contributor Author

Jongy commented Jul 18, 2022

Haven't tested yet though.

I hope this resolves

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000000000059a114 in machine__process_bpf_event_load (sample=<optimized out>, event=<optimized out>, machine=0x20574d0) at util/bpf-event.c:58

michelhe
michelhe reviewed Jul 20, 2022
View reviewed changes
Copy link

@michelhe michelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You think the CI is a good-enough cover ?

@Jongy
Copy link
Contributor Author

Jongy commented Jul 23, 2022

You think the CI is a good-enough cover ?

No, I added tests in #420, let's merge them first.

@Jongy
Copy link
Contributor Author

Jongy commented Jul 24, 2022

Oof no "update branch" button lol

@Jongy
Copy link
Contributor Author

Jongy commented Jul 24, 2022

@michelhe tests passed

@Jongy Jongy requested a review from michelhe July 24, 2022 14:12
michelhe
michelhe approved these changes Jul 24, 2022
View reviewed changes
Copy link

@michelhe michelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥂

@Jongy Jongy merged commit 5c6b501 into master Jul 24, 2022
@Jongy Jongy deleted the upgrade-perf branch July 24, 2022 14:49
@Jongy Jongy mentioned this pull request Aug 4, 2022
Merged
@Jongy Jongy mentioned this pull request Oct 18, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@michelhe michelhe michelhe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jongy @michelhe