Skip to content

Conversation

@Jongy
Copy link
Contributor

@Jongy Jongy commented Jul 23, 2022

These sanity test FP, DWARF and smart modes on 2 applications: one built with FP only, and one built without
FP but with DWARF.

@Jongy Jongy added the enhancement New feature or request label Jul 23, 2022
@Jongy Jongy requested a review from michelhe July 23, 2022 13:44
Jongy added 2 commits July 23, 2022 16:45
These sanity test FP, DWARF and smart modes on 2 applications: one built with FP only, and one built without
FP but with DWARF.
@Jongy
Copy link
Contributor Author

Jongy commented Jul 23, 2022

The failure is flakiness:

>           assert is_function_in_collapsed(";_start;__libc_start_main;main;", process_collapsed) ^ bool(
                perf_mode not in ("dwarf", "smart")
            )
E           AssertionError: assert (False ^ False)
E            +  where False = is_function_in_collapsed(';_start;__libc_start_main;main;', Counter({'native;[unknown];__libc_start_main;main;recursive;recursive;recursive;recursive;recursive;recursive;recursiv...ist_rcv_[k];ip_sublist_rcv_[k];ip_rcv_finish_core.isra.0_[k];tcp_v4_early_demux_[k];__inet_lookup_established_[k]': 1}))
E            +  and   False = bool('smart' not in ('dwarf', 'smart'))

the thing is, kernel stacks are taken into account when calculating the average, which introduces flakiness because kernel stacks can not be anticipated.
I changed the code so kernel stacks are not taken into account

@Jongy
Copy link
Contributor Author

Jongy commented Jul 23, 2022

Tests passed first time, running again to ensure no flakiness.

@Jongy
Copy link
Contributor Author

Jongy commented Jul 24, 2022

2nd time all passed, running again.

@Jongy
Copy link
Contributor Author

Jongy commented Jul 24, 2022

Screenshot from 2022-07-24 10-39-05

Copy link

@michelhe michelhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Jongy Jongy merged commit 5242a5b into master Jul 24, 2022
@Jongy Jongy deleted the perf-tests branch July 24, 2022 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants