Skip to content

Moving requirement to handle flake8 issue to the CI instead of the requirements.txt #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Moving requirement to handle flake8 issue to the CI instead of the requirements.txt #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b88309
Moving requirement to handle flake8 issue to the CI instead of the re…
tomersa Oct 4, 2022
246c2d5
fix
tomersa Oct 4, 2022
e52e1ab
fix
tomersa Oct 4, 2022
87a939e
fix
tomersa Oct 4, 2022
4710782
fix
tomersa Oct 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/glogger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -r dev-requirements.txt
pip install --force-reinstall importlib_metadata~=4.8 # Added requirement separately since it stems from an errorneous lint. See the following link for more details: https://github.com/Granulate/granulate-utils/pull/82#discussion_r985745999
Copy link
Contributor

@Jongy Jongy Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why separately and not in dev-requirements? And why --force-reinstall?

Copy link
Contributor Author

@tomersa tomersa Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the comment wasn't clear, importlib_metadata==5 is installed as it is a requirement of 1 of the packages used by granulate-utils/gLogger. I need importlib_metadata~=4.8 so I must reinstall it in order for it to work.

It is separate from dev-requirements.yml because it should be temporary until they fix the problematic requirements in the link suggested.

Copy link
Contributor

@Jongy Jongy Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it like intel/gprofiler#519?

Copy link
Contributor Author

@tomersa tomersa Oct 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's the same issue actually. If you manage to make it work by upgrading flake8 LMK. I'll remove the fix here

Copy link
Contributor

@Jongy Jongy Oct 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I managed. Do the same fix here and remove the importlib_metadata thing


- name: Run linters
run: ./lint.sh --ci
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
python -m pip install --upgrade pip
pip install -r requirements.txt
pip install -r dev-requirements.txt
pip install --force-reinstall importlib_metadata~=4.8 # Added requirement separately since it stems from an errorneous lint. See the following link for more details: https://github.com/Granulate/granulate-utils/pull/82#discussion_r985745999

- name: Run linters
run: ./lint.sh --ci
1 change: 0 additions & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,3 @@ dataclasses~=0.8; python_version < '3.7'
typing-extensions>=4.1.0
pyelftools~=0.28
packaging~=21.2
importlib_metadata~=4.8