add y_dtype op overload for expected_weights_desc#361
Merged
Conversation
Contributor
Author
|
@mingfeima @Xia-Weiwen @yanbing-j @aditew01 @nikhil-arm @fadara01, requesting for review. |
aditew01
approved these changes
Jul 22, 2026
aditew01
reviewed
Jul 22, 2026
Contributor
|
@LuFinch @yanbing-j can you please take a look? |
Contributor
|
@copilot review |
Contributor
|
please apply the existing indentation suggestion |
Co-authored-by: Aditya Tewari <aditya.tewari@arm.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the y_dtype op overload in the expected_weights_desc.
This change will allow users to explicitly specify the output dtype. For AARCH64, we can call this overload with the output_dtype yielding an optimal layout (e.g. fp32).
The corresponding change in PyTorch is raised here : pytorch/pytorch#185910